Skip to content

docs(generic): sync template standards updates#345

Merged
mberlofa merged 1 commit into
mainfrom
docs/generic-template-standards-sync
Jul 6, 2026
Merged

docs(generic): sync template standards updates#345
mberlofa merged 1 commit into
mainfrom
docs/generic-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • document Generic ingress class behavior and networkPolicy.extraEgress
  • add Generic to the playground registry with curated defaults
  • sync the configuration reference for the new NetworkPolicy value

Validation

  • make site-sync-check CHART=generic
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Charts PR: helmforgedev/charts#667
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features

    • Added a new generic chart configuration to the playground, making it available alongside existing charts.
    • Included curated setup options for workloads, ingress, resources, and network policy in the generic chart.

  • Documentation

    • Clarified ingress behavior for the generic chart when no ingress class is set.
    • Reformatted the security and storage reference table for easier reading.

@mberlofa mberlofa mentioned this pull request Jul 3, 2026
Merged
@coderabbitai

coderabbitai Bot commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ff800c6-5b0c-4592-8202-b60aa2235dfc

📥 Commits

Reviewing files that changed from the base of the PR and between 24a33aa and d260959.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/generic.mdx
  • src/pages/playground.astro
✅ Files skipped from review due to trivial changes (1)
  • src/pages/docs/charts/generic.mdx
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/pages/playground.astro
  • src/data/playground-configs.ts
📝 Walkthrough

Walkthrough

Adds a new generic chart configuration entry, wires generic into the playground chart registry, and updates the generic chart documentation for ingressClassName and table formatting.

Changes

Generic Chart Playground Support

Layer / File(s) Summary
Generic chart playground field definitions
src/data/playground-configs.ts		 Adds a generic chart config with workload, ingress, resources, and network policy field groups.
Enable generic chart in playground page
src/pages/playground.astro		 Registers generic in siteSyncPlaygroundConfigs, allowing it to pass the playground chart gating.
Generic chart docs updates
src/pages/docs/charts/generic.mdx		 Clarifies empty ingress.ingressClassName behavior and reflows the Security and Storage configuration reference table.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • helmforgedev/site#322: Also extends siteSyncPlaygroundConfigs in src/pages/playground.astro with another chart slug.
  • helmforgedev/site#330: Modifies the same playground chart registry and filtering path with a different chart entry.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly reflects the Generic docs/playground sync for template updates.
Description check ✅ Passed The description covers the summary, validation, and related issue; it only omits the template’s Quality Gates checkbox list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/generic-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa mberlofa mentioned this pull request Jul 3, 2026
Closed
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
@mberlofa
fix(generic): align template standards (#667)
b03032f 
## Summary
- guard Generic `ingressClassName` rendering so empty values omit
`spec.ingressClassName`
- rename the ExternalSecret template to the canonical
`externalsecret.yaml` name
- add `networkPolicy.extraEgress` support with schema and unit coverage,
and centralize validation through the chart validate helper

## Validation
- helm unittest charts/generic
- helm lint --strict charts/generic
- make template-standards-check CHART=generic
- make standards-check CHART=generic
- make standards-guard CHART=generic
- make validate-chart CHART=generic TIMEOUT=900: FULLY VALIDATED (18
layers)
- make site-sync-check CHART=generic
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#345
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added `networkPolicy.extraEgress` to append egress rules and include
the `Egress` policy type when applicable.
  * Chart validation now enforces additional render-time value checks.
* Ingress omits `spec.ingressClassName` when `ingress.ingressClassName`
is set to `""`.
* **Documentation**
* Updated `networkPolicy` guidance for `defaultDeny` and `extraEgress`.
* **Bug Fixes**
* PodDisruptionBudget now selects `minAvailable`/`maxUnavailable` based
on key presence (so `0` is handled correctly).
* **Tests**
* Expanded validation, Ingress, security (extra egress), PDB, and
validation failure/success scenarios; updated one ExternalSecret test
template reference.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/generic-template-standards-sync branch from 24a33aa to d260959 Compare July 6, 2026 13:04
@mberlofa mberlofa merged commit c5d243b into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/generic-template-standards-sync branch July 6, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mberlofa